Repository navigation
fix(sessions): preserve every distinct history blocker - #4715
Closed
ScriptedAlchemy wants to merge 1 commit into
Closed
ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
|
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This was referenced Nov 3, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
pass_reason_coderetained only the first matching failure for each provider withBTreeMap::entry(...).or_insert(...). A provider reporting an invalid observation followed byprojection_store_corrupttherefore lost the corruption reason before the worker logged the outcome or published its typed serving status. Source order could change the operator-visible diagnosis while the actual failures were identical.Change
Collect distinct
(provider, reason)pairs in canonical order rather than one reason per provider. Preserve raw codes for single-provider passes and existing provider-qualified codes for multi-provider passes. Duplicate failures do not repeat the same reason. Nonretryable failures still take precedence over retryable siblings, and healthy-provider progress remains intact.This is the existing history-outcome/status path; no new event store, timer, retry policy, wire field, authorization rule, or recovery mechanism is introduced.
Regression coverage
Added three behavioral tests through the real outcome classifier:
SessionTemporalRefreshWakeStateserving-status handle, and clear on a subsequent Complete outcome.Existing single-reason, mixed-provider, progress, and retry tests remain unchanged.
Verification
Reviewed the project/profile ingestors, outcome classifier, worker consumer, and typed status mapping. The complete GitHub-generated commit diff changes only reason aggregation, its documentation, test imports, and the three added regressions.
No local compilation, rustfmt, Clippy, or test execution is claimed. This environment has no supplied checkout, Bazel, rustc, or rustfmt, and direct source downloads fail DNS. No Cargo commands were run. Hosted Bazel CI must validate
//crates/tracedecay-session-runtime:unit_testand the affected session/status journeys before merge.Refs #4569 (corrupt-store visibility). This fixes information loss in the existing status path; it does not implement relational-store rebuild, prove a production corruption recovery, or complete Doctor's remaining recovery guidance. Keep the issue open.